Set specific non-UTF8 encodings for 2 known files in .gitattributes#2496
Set specific non-UTF8 encodings for 2 known files in .gitattributes#2496Avasam merged 5 commits intomhammond:mainfrom
Conversation
| version(1.1), | ||
| // an extended character in the help string should stress things... | ||
| helpstring("Python COM Test Harness 1.0 Type Library, � pywin32 contributors") | ||
| helpstring("Python COM Test Harness 1.0 Type Library, © pywin32 contributors") |
There was a problem hiding this comment.
This is one of only 2 places where this symbol is used. The other being
pywin32/win32/Lib/win32timezone.py
Line 10 in c5a30d2
Everywhere else is either (c) (136 times) or (C) (17 times)
It could just be changed to (c)
|
In general we're not testing a specific encoding, just trying to avoid mojibake etc - I'd be fine with making everyting utf-8 except there the encoding really does specifically matter. |
For It'd be nice if it worked as UTF-8 as well. But I'm not certain of the proper change to make that work in UTF-8. For |
|
|
||
| // @pymethod <o PyIStream>|PyIStorage|CreateStream|Creates and opens a stream object with the specified name contained | ||
| // in this storage object. All elements within a storage object � both streams and other storage objects � are kept in | ||
| // in this storage object. All elements within a storage object, both streams and other storage objects, are kept in |
There was a problem hiding this comment.
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
it looks like the commit message no longer matches the patch? ie, aren't you just replacing a unicode char with an ascii one?
|
@mhammond maybe you're only looking at the last commit? The full PR description still applies. .gitattributes changes for 2 necessary files (everything else is utf-8) and fixing <?> chars due to previously incorrect re-encoding. |
|
oops, indeed I was - I followed the wrong link - thanks! |
2 participants
I added the entries to
.gitattributes.I opened
com/TestSources/PyCOMTest/PyCOMTest.idlasISO-8859-1, fixed the "unknown characters", then saved under that encoding.Finally I ran
git add --renormalize .for the changed files